Skip to content

feat: refactor max and abs tests - #69

Merged
andrew-field merged 1 commit into
masterfrom
refactor-max-abs
Jul 7, 2025
Merged

feat: refactor max and abs tests#69
andrew-field merged 1 commit into
masterfrom
refactor-max-abs

Conversation

@andrew-field

Copy link
Copy Markdown
Owner

No description provided.

@andrew-field andrew-field self-assigned this Jul 7, 2025
@codecov

codecov Bot commented Jul 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (0098f77) to head (11d41f9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          10       10           
  Lines         501      501           
=======================================
  Hits          483      483           
  Misses         12       12           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrew-field
andrew-field requested a review from Copilot July 7, 2025 19:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors various test suites by standardizing result fields, consolidating error/result assertions into helper functions, and updating example output for Abs.

  • Rename expectedResult/expectedDigits to want across tests for consistency.
  • Replace inline error and result checks with checkError and checkResults helpers.
  • Update the ExampleAbs output message to include “The”.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
max_abs_test.go Renamed fields to want, used helpers, and tweaked ExampleAbs output
gcd_lcm_test.go Removed manual errors.Is checks in favor of checkError
divisors_test.go Dropped redundant comment in divisor tests
digits_test.go Renamed expected fields to want and streamlined assertions
binomial_factorial_test.go Swapped inline error checks for checkError

Comment thread max_abs_test.go
@andrew-field
andrew-field merged commit 4734452 into master Jul 7, 2025
7 checks passed
@andrew-field
andrew-field deleted the refactor-max-abs branch July 7, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants