Remove unused call to String#replaceAll(). - #546
Merged
Conversation
Member
|
Wow entertaining. We must be too used to Ruby Strings :) The real question I have about this is why this was there in the first place. We clearly have no coverage for this code but should it be fixed or removed? |
Member
|
Yeah, this line obviously does nothing. I'm looking to see whether its intended purpose is needed, but removing it is not a problem. |
headius
added a commit
that referenced
this pull request
Feb 26, 2013
Remove unused call to `String#replaceAll()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this
replaceAllshould be used, or if it's just a stray.