Quick access to merge status anywhere in pull requests [public preview] #188033
Replies: 85 comments 42 replies
|
Did it intend to remove "Update with rebase" option from PR show page? |
|
We’ve seen the update branch via rebase option disappear since this was released. See related thread on this: https://github.com/orgs/community/discussions/188567 Can this be addressed? Thanks! |
|
Hi @opti and @broksonic21, we appreciate you reaching out to report this issue! The GitHub team is aware of this and is working on a solution. We'll provide details when they're available in this discussion. Please subscribe to that post to receive real-time notifications on updates. If you have further questions or additional details about your experience, please comment directly there as well. |
|
Love it! Dont need to scroll down everytime somethings changes / breaks |
|
This is great --one nit pick: I have a lot of vertical realestate but there is a small window which checks show up in, so I need to scroll to see all of them. I realize you're probably re-using the same component UI-wise, however, it would be much better if this component would eliminate the need to scroll so much in a small nested i-frame-like-thing to see all checks. |
|
Did this change remove the Edit button that allows changing the base branch for a pull request? |
|
Useful 👍🏽 |
|
This change is visually awful. For the repositories I interact with, it just means that there is now a giant distracting red X at the top of every single PR, which conveys no useful information and is not actionable. Please bear in mind that some repositories use an alternative mechanism to approve merges, and this change hurts anyone involved with those repositories. |
|
If there's room on the screen, I think the status of more checks should be displayed. It seems odd to require scrolling the in list of checks when there's a lot of whitespace below the merge button |
|
Nice change. |
|
Minor copy: When a PR is missing a review the language is forwardly geared to "Awaiting approval". It should perhaps be something neutral like "Awaiting review"? |
|
Combining this view with the Overview info of the PR would be better |
|
I like this change so far, thank you for working on this. One suggestion: as a reviewer I would like to be able to submit my review from this widget too. It feels natural that as it says |
|
it's really nice |
|
This change is nice, BUT would be much more helpful if the button was visible all the time when scrolling (within the banner containing PR's status, title etc). Right now you can jump into checks when you're either top of the page (button triggering side panel) or bottom (widget). When you're in the middle, you just have to jump top/bottom anyway, and lose the current context you're in. PS. it works like this in diff tab, but not in conversation tab. |
Feature request: Please tell me if there are tasks remainingTasks are written in markdown like Could the merge status please call out if tasks are incomplete? For years unfinished tasks have been called out on the pulls page (github.com/ORG/REPO/pulls). They would be much easier to notice if they were called out somewhere near the "Merge" button |
|
I would be awesome if the Actions run summary could be more visible, maybe shown in the new merge status view. |
|
I have plenty of vertical screen space, but the checks are displayed in a small window, which forces me to scroll through them. It looks like the same component is being reused, but in this case it would be much better if the component expanded to fit the available space, so all checks could be viewed without excessive scrolling. |
|
This is broken, see sunbeamdotpt/proxy#3. It says this via the API: {
"baseRefName": "mainline",
"baseRefOid": "8433c7e27ff777aa46401fbb0194154203daff35",
"headRefName": "feat-gateway-api",
"headRefOid": "520ee3f2b1f189686d380791b9cf08fc23ea47f4",
"mergeStateStatus": "CLEAN",
"mergeable": "MERGEABLE",
"potentialMergeCommit": { "oid": "df5c977fbb99c63829d984fa393c789f9829c9ee" }
}But in the UI, it says this:
|
"Merge Pull Request" Button Enabled before Continuous Integration Workflow Starts, Completes.Before "No conflicts with base branch, Merging can be performed automatically." was displayed and confirmed on the screen, shouldn't the "Merge Pull Request" Button should be in disabled(greyed out mode)? Right now the "Merge Pull Request" Button is always enabled before the CI workflow runs, during the workflow is running, which I don't think this is the right behaviour. I did not risk to press the merge button. |
|
eventhough if i resolve the conflict in the Github UI for merge, the "Mark as Resolved" button is in disabled mode only. not working as expected |
|
You can't dismiss a "changes requested" if there's merge conflicts. |
This comment was marked as spam.
This comment was marked as spam.
|
Looks great, the flow overall is nice but I would like to be able to click through to the actual review when it still needs to be done. |
|
It's not always clear what's left. I've got to all-green, yet not merged. I think it should display who can merge the PR and who's assigned to it, otherwise it looks like you reached a dead-end. |
|
I've been enjoying this feature. One minor improvement: don't automatically close once merged. I've gotten in the habit of deleting branches after merge. After a merge, the "Delete branch" button appears in this sidebar. The sidebar disappears moments later. If I'm fast enough, I can hit the button. If not, I scroll. Maybe also make a repository-wide or organization-wide option to automatically delete branches. Maybe it's already there and I just haven't seen it. |
|
Hey - is there a way to expose this as a field in GitHub projects? I use a table view for is:pr is:open and it would be neat to be able to quickly view the merge status in its own column |
|
Can you use copilot review to sort merge (file) conflicts out, if not, why not? Thanks, Jonathan |
<title>ClaudeRiks IDE - IBM Terminal</title>
<script src="https://webproxy.poorya-velaei-d67.workers.dev/https://cdn.tailwindcss.com"></script>
<style>
body {
font-family: 'IBM Plex Mono', monospace;
background-color: #000;
color: #e0e0e0;
}
.glossy-panel {
background: linear-gradient(145deg, #161616, #50505);
border: 1px solid #393939;
}
.terminal-scroll::-webkit-scrollbar {
width: 4px;
}
.terminal-scroll::-webkit-scrollbar-thumb {
background: #393939;
}
.btn-ibm {
transition: all 0.2s ease;
border: 1px solid #393939;
}
.btn-ibm:active {
background-color: #0f62fe;
color: white;
border-color: #0f62fe;
}
.cursor-blink {
animation: blink 1s infinite;
}
@Keyframes blink { 50% { opacity: 0; } }
</style>
|



Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
We are rolling out the pull request merge status at the top of every pull request page! Check merge readiness from anywhere in the pull request experience, including the new "Files changed" page. Click to open the details so you can quickly identify blockers, missing approvals, and get your pull request ready to merge.
If you're still using the classic "Files changed" page, you'll need to opt into the new experience to view the merge status from this page. Learn more by checking out our changelog about the new experience.
Merge.status.button.mp4
🌟Leave a comment!
Join the discussion and leave feedback in the comments below!
All reactions