Require review from specific team setting specifics? #191347
Replies: 3 comments
|
No, GitHub currently requires the team to appear as reviewers if you enforce a team based review rule. So it cant be hidden |
|
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
|
The short answer is: no, GitHub doesn't currently support enforcing a team review without surfacing the team as required reviewers on the PR. But here's a workaround that gets close to what you want: Only that smaller team gets notified, not all 60+ members For the merge queue concern: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Question
Body
Hi, I'm looking to get some clarity on the
Require review from specific teamsetting on branch rulesets. Previous to this feature, we wanted to add a member from senior-eng-team to be a required reviewer, without notifying everyone in the group (large 60+ group). We wanted the author to look through the group and pick an appropriate reviewer. We also wanted to use the merge queue.To accomplish this, we had:
Restrict who can push to matching brancheslist.Together, those two settings made it so that for any PR targeting that branch, only a member of senior-eng-team can see the 'Merge when ready' button. It didn't necessarily require a review, but it would implicitly, since the author needed to find a senior-eng-team member to click 'Merge when ready'.
I found this setting
Require review from specific teamthat seems to be able to better accomplish what I'm looking for, with caveat, but would like to confirm my understanding. If I use just the ruleset with merge queue enabled, andRequire review from specific teamset up with senior-eng-team for * files, I see that on the PR:Is there a way to enforce a review from a senior-eng-team member without adding the team slug to the list of reviewers?
All reactions