Skip to content

fix some errors - #298

Merged
Ehco1996 merged 3 commits into
Ehco1996:masterfrom
xpzouying:master
Mar 18, 2024
Merged

fix some errors#298
Ehco1996 merged 3 commits into
Ehco1996:masterfrom
xpzouying:master

Conversation

@xpzouying

@xpzouying xpzouying commented Mar 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • check error twice
  • handle replace flag when init logger

@xpzouying
rm unnecessary code
2dca73f 
* check error twice
@xpzouying
log: handle replace flag when init logger
e7e402e 
replace global logger when replaceGlobal is true.
@xpzouying xpzouying changed the title rm unnecessary code fix some errors Mar 17, 2024
Ehco1996
Ehco1996 approved these changes Mar 18, 2024
View reviewed changes

@Ehco1996 Ehco1996 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ehco1996
Ehco1996 merged commit 719ff86 into Ehco1996:master Mar 18, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xpzouying @Ehco1996