fix(updater): detect nightly tag republish - #454
Merged
Conversation
Nightly uses a rolling tag (v1.1.7-next), so version-string equality made `Check` and `Apply` short-circuit to "already up to date" even after a fresh nightly was published. Both ldflag paths (goreleaser and Makefile) inject BuildTime, so compare release.published_at against the local BuildTime when versions match. Stable channel is unaffected since its tags don't roll. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.1.7-next), so version-string equality madeupdater.Check/Applyshort-circuit to "already up to date" even after a fresh nightly release.published_atagainst the local ldflag-injectedBuildTimeto detect republished nightly builds. Stable channel is unaffected.{{.Date}}) and Makefile2006-01-02-15:04:05. Empty / unparseable BuildTime falls back tofalseso barego builddoesn't trigger false positives.Test plan
go test ./internal/updater/... -count=1(addedTestParseBuildTime,TestNightlyRepublished)make lintCheckin the dashboard against the latest republished nightly — should show update available;Applyshould proceed and restart cleanly.🤖 Generated with Claude Code