chore(deps): upgrade dependencies and fix stdlib vulnerability - #246
Conversation
- Upgrade charmbracelet/bubbles v0.21.1 -> v1.0.0 (ceremonial release, typo fix only) - Upgrade golang.org/x/term v0.39.0 -> v0.40.0 - Upgrade golang.org/x/text v0.33.0 -> v0.34.0 - Upgrade golang.org/x/crypto v0.47.0 -> v0.48.0 (indirect, security patch) - Upgrade golang.org/x/net v0.49.0 -> v0.50.0 (indirect, security patch) - Upgrade golang.org/x/sys v0.40.0 -> v0.41.0 (indirect) - Upgrade Go toolchain go1.24.5 -> go1.25.7 (fixes GO-2026-4337: unexpected session resumption in crypto/tls) govulncheck reports 0 vulnerabilities after upgrade.
|
Caution Review failedFailed to post review comments 📝 WalkthroughSummary by CodeRabbit
WalkthroughGo toolchain bumped to 1.25.7 and direct dependency Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR upgrades several Go dependencies and the Go toolchain itself, with the stated purpose of addressing a security vulnerability in crypto/tls. However, there are critical issues with version references that need to be addressed before this can be merged.
Changes:
- Upgrade charmbracelet/bubbles from v0.21.1 to v1.0.0 (noted as ceremonial release)
- Upgrade several golang.org/x/* packages (term, text, crypto, net, sys) to newer versions
- Upgrade Go toolchain from go1.24.5 to go1.25.7
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| go.mod | Updates direct and indirect dependency versions, upgrades Go toolchain to go1.25.7 |
| go.sum | Updates checksums for all upgraded dependencies to match the new versions specified in go.mod |
Update mise.toml Go version (1.25.6 -> 1.25.7), requirements.md toolchain reference (go1.24.5 -> go1.25.7), and compatibility research doc bubbles version (v0.21.0 -> v1.0.0) to match the actual dependency state after upgrades.
Summary
charmbracelet/bubblesv0.21.1 -> v1.0.0 (ceremonial release, no breaking changes)golang.org/x/termv0.39.0 -> v0.40.0golang.org/x/textv0.33.0 -> v0.34.0golang.org/x/cryptov0.47.0 -> v0.48.0 (security patch)golang.org/x/netv0.49.0 -> v0.50.0 (security patch)golang.org/x/sysv0.40.0 -> v0.41.0go1.24.5->go1.25.7(fixes GO-2026-4337: unexpected session resumption incrypto/tls)Test Plan
just ci-checkpasses (0 lint issues, all tests green)govulncheck ./...reports 0 vulnerabilitiesgo build ./...succeedsgo test ./...all packages pass🤖 Generated with Claude Code