Add VirtletRootVolumeSize annotation - #742
Conversation
0.3.5 has bad growroot that doesn't really work when we enlarge the libvirt volume
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Everything looks perfect, but could you also add an example annotation to one .yamls in examples/?
Maybe also that could be noted somewhere in https://github.com/Mirantis/virtlet/blob/master/docs/volumes.md ?
Reviewed 14 of 14 files at r1.
Reviewable status: 0 of 2 LGTMs obtained
This fixes CirrOS 0.4.0 compatibility.
ivan4th
left a comment
ivan4th
left a comment
There was a problem hiding this comment.
@jellonek Done.
Reviewable status: 0 of 2 LGTMs obtained
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale
pigmej
left a comment
pigmej
left a comment
There was a problem hiding this comment.
Reviewed 13 of 14 files at r1, 5 of 6 files at r2, 1 of 1 files at r3.
Reviewable status: 1 of 2 LGTMs obtained, and 1 stale
3 participants
This makes it possible to enlarge the root volume of VM.
This PR also adds an e2e test for
VirtletRootVolumeSize, which requires updating the default CirrOS image to 0.4.0 which has propergrowrootincluded (growrootfrom CirrOS 0.3.5 didn't notice that the block device was larger then specified in the partition table)This change is