Feat/add insecure grpc connection - #130
Merged
Merged
Conversation
Signed-off-by: jdiaconu <jdiaconu@cisco.com>
Signed-off-by: jdiaconu <jdiaconu@cisco.com>
jadiaconu
requested review from
beryder,
copasseron,
hmuyal,
mayannuz,
mkedjour and
rafaelsilva29
as code owners
August 29, 2025 07:38
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
copasseron
previously approved these changes
Aug 29, 2025
Signed-off-by: jdiaconu <jdiaconu@cisco.com>
Signed-off-by: jdiaconu <jdiaconu@cisco.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for insecure gRPC connections to the Identity SDK, allowing developers to connect to local gRPC services without SSL/TLS encryption. This is useful for development and testing scenarios where secure connections are not required.
- Introduces
IDENTITY_NODE_USE_SSL_INSECUREenvironment variable to control SSL behavior - Refactors connection logic to support both secure and insecure gRPC channels
- Updates SDK version from 0.0.17 to 0.0.18
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/python/pyproject.toml | Bumps version to 0.0.18 and adds new contributor |
| sdk/python/agntcyidentity/client.py | Refactors gRPC connection logic to support insecure channels and renames environment variables |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+52
to
+53
| channel_credentials = None | ||
|
|
There was a problem hiding this comment.
[nitpick] Setting channel_credentials = None and then conditionally overriding it creates unnecessary complexity. Consider initializing it directly in the conditional blocks or using a more explicit default value.
Suggested change
| channel_credentials = None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a possibility to connect over a local insecure channel for the gRPC SDK connection.
Type of Change
Checklist