feat(issuer): added custom common name parsers for microsoft entra & ping - #159
Merged
Merged
Conversation
…d ping Signed-off-by: Mohamed Tahar KEDJOUR <mkedjour@cisco.com>
mkedjour
requested review from
beryder,
copasseron,
hmuyal,
jadiaconu,
mayannuz and
rafaelsilva29
as code owners
January 26, 2026 16:23
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix to adapt Microsoft Entra and Ping IdPs.
The problem is that when we try to construct the issuer's common name using the
issclaim, we always getlogin.microsoftonline.comandauth.pingone.*no matter the tenant.The quick fix consists of detecting these two IdPs when we parse the common name and injecting the tenant ID as a sub domain from the URL path.
Type of Change
Checklist