Skip to content

fix: roster prune + clear verify DETAIL_ERRORs - #199

Merged
amikai merged 4 commits into
mainfrom
fix/verify-roster-and-detail-paths
Jul 17, 2026
Merged

fix: roster prune + clear verify DETAIL_ERRORs#199
amikai merged 4 commits into
mainfrom
fix/verify-roster-and-detail-paths

Conversation

@amikai

@amikai amikai commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up from a full verify-companies sweep across all roster providers.

  • Ashby roster: remove 2 boards confirmed 404 (Continue, Roo Code). No supported-ATS migration found for those slugs.
  • Eightfold: publicUrl may be JSON null (NetApp, Houston ISD); make it nullable and fall back to origin + positionUrl.
  • Workday: accept location-less externalPath values (/job/{titleSlug}) used by tenants such as BSI, LVHN, VUMC.
  • SuccessFactors: multi-brand tenants omit itemprop="title"; fall back to og:title / document title (Endress+Hauser, Knorr-Bremse, MediaMarktSaturn).
  • iCIMS: some portals serve live iframe detail without JobPosting JSON-LD; scrape h1.iCIMS_Header + expandable text.
  • verify-companies: auto-cap Recruitee at 2 concurrent workers so default concurrency does not trip HTTP 429s.

Test plan

  • go test for affected packages (workday, successfactors, icims, eightfold, ats, verify-companies)
  • go run ./cmd/verify-companies --provider ashby → 1275 OK, 0 error
  • eightfold, successfactors, icims, workday, recruitee re-sweeps clean (or only transient 5xx cleared on retry)

amikai added 3 commits July 17, 2026 06:00
Drop Continue and Roo Code after verify-companies confirmed HTTP 404 on
the Ashby posting API. Neither board has a working careers URL on a
supported ATS under those names.
- eightfold: allow null publicUrl; fall back to origin + positionUrl
- workday: accept location-less /job/{titleSlug} externalPaths
- successfactors: title from og:title / document title when itemprop missing
- icims: scrape iframe chrome when JobPosting JSON-LD is absent
- verify-companies: cap recruitee concurrency at 2 to avoid 429 noise
PublicUrl is OptNilString after the null-tolerant OpenAPI change; compare
via Get() and fall back to site-relative positionUrl.
Comment thread cmd/verify-companies/main.go
Comment thread cmd/eightfold/main.go Outdated
Comment thread internal/provider/workday/openapi.yaml
- Acquire Recruitee sub-cap before the global worker slot so waiters
  cannot starve other providers
- Compose absolute eightfold detail URLs from tenant origin + positionUrl
- Regenerate Workday ogen client so location-less path docs stay in sync
Repository owner deleted a comment from cursor Bot Jul 17, 2026
@amikai
amikai merged commit a34512c into main Jul 17, 2026
9 checks passed
@amikai
amikai deleted the fix/verify-roster-and-detail-paths branch July 17, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant