Add a lint check for zerolog expression statements without Send or Msg calls - #907
Merged
Merged
Conversation
github-actions
Bot
added
the
area/tooling
josephschorr
force-pushed
the
zerolog-lint-check
branch
from
October 17, 2022 19:18
4b25573 to
635e6ca
Compare
josephschorr
marked this pull request as ready for review
October 17, 2022 19:25
vroldanbet
previously approved these changes
Oct 18, 2022
jzelinskie
reviewed
Oct 18, 2022
Member
There was a problem hiding this comment.
Do you also need testdata where these types are used?
Member
Author
There was a problem hiding this comment.
Yes, my file somehow went missing... I just recreated it and added it back
josephschorr
force-pushed
the
zerolog-lint-check
branch
from
October 18, 2022 15:03
635e6ca to
54ba03c
Compare
vroldanbet
approved these changes
Oct 18, 2022
jzelinskie
approved these changes
Oct 18, 2022
josephschorr
force-pushed
the
zerolog-lint-check
branch
from
October 18, 2022 15:54
54ba03c to
83345d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #905