Enhance scripts/include.go and fix warnings - #516
Merged
Conversation
Write tmp data to a buffer rather than a temp file. This is faster and robuster.
apocelipes
force-pushed
the
enhance-scripts
branch
from
September 27, 2024 09:11
d3ad3a8 to
c8f09b4
Compare
apocelipes
changed the title
Owner
|
Thanks for this. This was something I was starting to look at actually as id like to remove the need for JSON at all inside the application. This is a good stepping stone to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write tmp data to a buffer rather than a temp file. This is faster and robuster.
Fix some golangci-lint warnings.
Fix a miss use of break, a break in a switch only stop the switch statment, to stop the outer for-loop we need a label.