Print command line completions - #606
Merged
Merged
Conversation
Owner
|
OK I have no idea how this works and thus no way to verify its doing what it needs. How do I trigger this to verify it? |
Contributor
Author
Owner
|
Ah gotcha. Im going to merge then and mess around with it. Thanks for this. We can keep track on the linked issue. |
|
Great, I like it. I think changing the completion generation from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is a prototype for command line completions (#337).
Doing it the same way as other applications potentially interferes with existing
scccommand line argument parsing. In particular, users may want to count the LOC in thecompletionsub-directory, soscc completionwould lead to unexpected results.I made it so that command line completions are generated only if the arguments are
scc completion --shell [name of shell]. The--shelloption should prevent users from accidentally triggering this feature. It's nonetheless still a pretty ugly implementation. Perhaps a more elegant one exists?