Skip to content

Spelling - #16212

Merged
T-Gro merged 3 commits into
dotnet:mainfrom
jsoref:spelling
Aug 21, 2024
Merged

Spelling#16212
T-Gro merged 3 commits into
dotnet:mainfrom
jsoref:spelling

Conversation

@jsoref

@jsoref jsoref commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

As discussed in #16204

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/fsharp/actions/runs/6720404664/attempts/1#summary-18263884401

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/fsharp/actions/runs/6720404656/attempts/1#summary-18263884386

@jsoref
jsoref requested a review from a team as a code owner November 1, 2023 13:50
@psfinaki

psfinaki commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Damn... did not think it would be that bad :D
Hey do you think we could have these changes in chunks? Like, 100-150 in each so that this is more manageable to review? We could go by projects or folders.

jsoref
jsoref commented Nov 1, 2023
View reviewed changes

@jsoref jsoref left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll continue annotating this PR later...

Comment thread docs/tooling-features.md
Comment thread fcs-samples/FsiExe/console.fs
Comment thread release-notes.md
Comment thread src/Compiler/AbstractIL/ilpars.fsy
Comment thread src/Compiler/AbstractIL/ilreflect.fs Outdated
Comment thread src/FSharp.Core/array.fs
Comment thread src/FSharp.Core/resumable.fs
Comment thread tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/flaterrors/env.lst
Comment thread ...Compiler.ComponentTests/Conformance/BasicGrammarElements/EntryPoint/E_invalidsignature001.fs
Comment thread ...nce/BasicGrammarElements/MemberDefinitions/MethodsAndProperties/E_AbstractAndConcreteProp.fs
@jsoref

jsoref commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

Sigh, I'll replace params and value with params_ and value_...

@vzarytovskii

vzarytovskii commented Nov 1, 2023

Copy link
Copy Markdown
Member

Hey do you think we could have these changes in chunks?

please no, it will kill git history, this way we only need to ignore one revision.

@jsoref

jsoref commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

Damn... did not think it would be that bad :D

For a project of this size, it's about as I'd expect (larger projects can get to ~1k commits).

@jsoref

jsoref commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

I'm on an m1 mac and can't figure out how to run the UpdateXlf thing. I have a mono, but that didn't help.

https://visualstudio.microsoft.com/vs/preview/#download-preview offers me an .exe which seems unhelpful on Darwin/macOS...

I'm tempted to just punt on the changes related to this.

@jsoref
jsoref force-pushed the spelling branch 4 times, most recently from 824ffd2 to e8516b5 Compare November 1, 2023 21:53
@jsoref

jsoref commented Nov 2, 2023

Copy link
Copy Markdown
Contributor Author

/run xlf

@github-actions

github-actions Bot commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

Ran xlf: https://github.com/dotnet/fsharp/actions/runs/6732262393

@jsoref
jsoref force-pushed the spelling branch 2 times, most recently from 548539d to 3da75d3 Compare November 3, 2023 14:25
jsoref
jsoref commented Nov 3, 2023
View reviewed changes

@jsoref jsoref left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is close to passing basic CI. I'm about halfway through annotating things. I'm off to visit a museum... I'll probably look back next week.

Comment thread tests/fsharpqa/Source/Conformance/TypeForwarding/Class/env.lst Outdated
Comment thread src/Compiler/xlf/FSComp.txt.cs.xlf Outdated
Comment thread src/Compiler/xlf/FSComp.txt.de.xlf Outdated
Comment thread vsintegration/src/FSharp.ProjectSystem.PropertyPages/PropertyPages/BuildPropPage.resx Outdated
Comment thread vsintegration/src/FSharp.ProjectSystem.PropertyPages/PropertyPages/PropPageUserControlBase.vb Outdated
Comment thread tests/fsharp/core/quotes/test.fsx Outdated
Comment thread tests/fsharp/core/seq/test.fsx Outdated
Comment thread vsintegration/src/FSharp.LanguageService.Base/EditArray.cs Outdated
Comment thread vsintegration/src/FSharp.ProjectSystem.Base/DataObject.cs Outdated
Comment thread vsintegration/src/FSharp.ProjectSystem.Base/Interfaces.cs Outdated
@jsoref
jsoref force-pushed the spelling branch 2 times, most recently from 654ca11 to cb505a9 Compare November 6, 2023 03:53
psfinaki
psfinaki reviewed Nov 6, 2023
View reviewed changes

@psfinaki psfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh, thanks for your grit. Looks like we are getting there... I am reviewing this, slowly but steadily :)

Looks like some of the spelling stuff spills to the user surface, so this benefits the language image also.

Comment thread ...rc/FSharp.ProjectSystem.PropertyPages/Resources/Microsoft.VisualStudio.Editors.Designer.resx Outdated
Comment thread vsintegration/src/FSharp.ProjectSystem.Base/Microsoft.VisualStudio.Package.Project.resx Outdated
Comment thread tests/fsharpqa/testenv/bin/runall.pl Outdated
Comment thread tests/fsharp/core/members/stephen.ml Outdated
@jsoref
jsoref force-pushed the spelling branch 3 times, most recently from 206b8fc to 3691487 Compare November 6, 2023 14:39
jsoref
jsoref commented Nov 7, 2023
View reviewed changes

@jsoref jsoref left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last round of me flagging interesting things -- I have one more push pending past this, and I think I have one or two more rounds of trying to fight CI, but at this point, it's very close to done and it's definitely quite reviewable.

Comment thread tests/FSharp.Compiler.ComponentTests/Conformance/Types/UnionTypes/E_FieldMemberClash.fs Outdated
Comment thread tests/FSharp.Compiler.ComponentTests/Conformance/Types/UnionTypes/ReflectionOnUnionTypes01.fs Outdated
Comment thread tests/FSharp.Compiler.ComponentTests/ErrorMessages/InterfaceImplInAugmentationsTests.fs Outdated
Comment thread tests/FSharp.Compiler.ComponentTests/Interop/DeeplyNestedCSharpClasses.fs Outdated
Comment thread tests/FSharp.Compiler.ComponentTests/Language/ObsoleteAttributeCheckingTests.fs Outdated
Comment thread tests/fsharpqa/Source/Misc/WhetherEmbeddedManifest.fs Outdated
Comment thread tests/service/data/SyntaxTree/DotLambda/UnderscoreToFunctionCallWithSpaceAndUnitApplication.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/Navigation/GoToDefinition.fs Outdated
Comment thread vsintegration/src/FSharp.ProjectSystem.Base/ProjectOptions.cs Outdated
Comment thread vsintegration/tests/MockTypeProviders/DefinitionLocationAttribute/ArtificialEventInfo.cs Outdated
psfinaki
psfinaki reviewed Nov 7, 2023
View reviewed changes
Comment thread tests/walkthroughs/sdk-script-manual-tests/README.md Outdated
jsoref
jsoref commented Nov 7, 2023
View reviewed changes
Comment thread ...qa/Source/Conformance/TypesAndTypeConstraints/LogicalPropertiesOfTypes/AllowNullLiteral01.fs Outdated
Comment thread tests/walkthroughs/sdk-script-manual-tests/README.md Outdated
psfinaki
psfinaki reviewed Nov 7, 2023
View reviewed changes
Comment thread vsintegration/tests/FSharp.Editor.Tests/CodeFixes/ReplaceWithSuggestionTests.fs Outdated
psfinaki
psfinaki approved these changes Feb 28, 2024
View reviewed changes

@psfinaki psfinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - I think it's ready :) 🚀

vzarytovskii
vzarytovskii previously requested changes Feb 28, 2024
View reviewed changes

@vzarytovskii vzarytovskii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not go before nullness changes, unless @T-Gro says otherwise.

@psfinaki

psfinaki commented May 6, 2024

Copy link
Copy Markdown
Contributor

Thanks for keeping this up-to-date, Josh :)

@psfinaki psfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 16, 2024
@jsoref

jsoref commented Aug 18, 2024

Copy link
Copy Markdown
Contributor Author

I expect to need to cherry-pick 4a5ca4b89902ed2dd4673cec1a5355fac4bdf24d again (possibly fixed up), but this is effectively a rebase of everything else along with iterating over check-spelling's output again.

I should note that spell-check-this (the compendium ruleset to check-spelling) has gotten a bit more clever since I last worked on this repository, so it's now complaining about things like a an or the a as well as it's own.

@jsoref
jsoref force-pushed the spelling branch 3 times, most recently from a3f3868 to 5d2ada1 Compare August 18, 2024 14:26
@psfinaki

psfinaki commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 19, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro
T-Gro enabled auto-merge (rebase) August 20, 2024 14:18
@psfinaki
psfinaki dismissed vzarytovskii’s stale review August 20, 2024 16:04

No more big PRs are blocking this, Vlad agrees

@psfinaki

psfinaki commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 21, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

psfinaki commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 21, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki

psfinaki commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 21, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro
T-Gro merged commit bd9e200 into dotnet:main Aug 21, 2024
@jsoref
jsoref deleted the spelling branch August 21, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments
+2 more reviewers
@KevinRansom KevinRansom KevinRansom approved these changes
@psfinaki psfinaki psfinaki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@psfinaki psfinaki

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsoref @psfinaki @vzarytovskii @KevinRansom @T-Gro