Skip to content

conformance: fix startup-home tilde expansion - #780

Merged
ewhauser merged 3 commits into
mainfrom
ewhauser/tilde-conformance-followups
Mar 29, 2026
Merged

conformance: fix startup-home tilde expansion#780
ewhauser merged 3 commits into
mainfrom
ewhauser/tilde-conformance-followups

Conversation

@ewhauser

Copy link
Copy Markdown
Owner

Summary

  • make ordinary argv-style tilde expansion prefer the shell startup home while keeping redirect and parameter-expansion behavior intact
  • use startup-home tilde semantics for compound-array keyed RHS values
  • remove stale tilde-related xfails from the bash conformance manifest

Testing

  • make lint
  • go test ./shell/expand ./internal/shell/interp
  • GBASH_CONFORMANCE_BASH=$(./scripts/ensure-bash.sh) GBASH_RUN_CONFORMANCE=1 go test ./internal/conformance -run 'TestConformance/bash/oils/(array-literal|array|brace-expansion|loop|word-split|tilde).test.sh$' -count=1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c350e74cd7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread shell/expand/expand.go Outdated
Comment thread internal/shell/interp/vars.go Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acafd8a51c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread shell/expand/expand.go Outdated
Comment thread internal/shell/interp/vars.go Outdated
@ewhauser
ewhauser merged commit bcb110b into main Mar 29, 2026
16 checks passed
@ewhauser
ewhauser deleted the ewhauser/tilde-conformance-followups branch March 29, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant