feat(context): add SaveUploadedFile func. - #1022
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 96.54% 96.56% +0.02%
==========================================
Files 16 16
Lines 1417 1428 +11
==========================================
+ Hits 1368 1379 +11
Misses 39 39
Partials 10 10
Continue to review full report at Codecov.
|
appleboy
requested changes
Jul 16, 2017
| c.String(http.StatusBadRequest, fmt.Sprintf("Create file err: %s", err.Error())) | ||
| return | ||
| if err := c.SaveUploadedFile(file, file.Filename); err != nil { | ||
| c.String(http.StatusBadRequest, fmt.Sprintf("upload file err: %s", err.Error())) |
| c.String(http.StatusBadRequest, fmt.Sprintf("file open err: %s", err.Error())) | ||
| return | ||
| if err := c.SaveUploadedFile(file, file.Filename); err != nil { | ||
| c.String(http.StatusBadRequest, fmt.Sprintf("upload file err: %s", err.Error())) |
Contributor
Author
|
@appleboy fixed. Thanks for your kind reminder. |
appleboy
approved these changes
Jul 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #674