Skip to content

return unsigned in database type name when necessary - #1238

Merged
shogo82148 merged 4 commits into
go-sql-driver:masterfrom
Lunny-forks:lunny/unsigned_type
Jul 18, 2021
Merged

return unsigned in database type name when necessary#1238
shogo82148 merged 4 commits into
go-sql-driver:masterfrom
Lunny-forks:lunny/unsigned_type

Conversation

@lunny

@lunny lunny commented Jul 18, 2021

Copy link
Copy Markdown
Contributor

Description

Currently it's impossible to know if the results column type is an unsigned type if the column allowed null.
Even if when column is not nullable, we can use ScanType to know if it's an unsigned type.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@shogo82148 shogo82148 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148
shogo82148 merged commit e8f8fcd into go-sql-driver:master Jul 18, 2021
@lunny
lunny deleted the lunny/unsigned_type branch July 19, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants