Skip to content

support parse redis acl for registry config - #22770

Merged
MinerYang merged 1 commit into
goharbor:mainfrom
MinerYang:support-redis-acl-distribution
Jan 23, 2026
Merged

support parse redis acl for registry config#22770
MinerYang merged 1 commit into
goharbor:mainfrom
MinerYang:support-redis-acl-distribution

Conversation

@MinerYang

Copy link
Copy Markdown
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

upstream fix: goharbor/distribution#7
Fixes #(#18892)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang
MinerYang requested a review from a team as a code owner January 22, 2026 16:55
@MinerYang
MinerYang force-pushed the support-redis-acl-distribution branch from b2dbe43 to 41d65ac Compare January 22, 2026 16:55
@MinerYang MinerYang changed the title support parse redis acl for distribution config support parse redis acl for registry config Jan 22, 2026
@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.87%. Comparing base (c8c11b4) to head (bf8f0c5).
⚠️ Report is 636 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22770       +/-   ##
===========================================
+ Coverage   45.36%   65.87%   +20.50%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116363   +103030     
  Branches     2719     2932      +213     
===========================================
+ Hits         6049    76649    +70600     
- Misses       6983    35469    +28486     
- Partials      301     4245     +3944     
Flag Coverage Δ
unittests 65.87% <ø> (+20.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 989 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: my036811 <miner.yang@broadcom.com>
@MinerYang
MinerYang force-pushed the support-redis-acl-distribution branch from 41d65ac to bf8f0c5 Compare January 23, 2026 07:49
@MinerYang
MinerYang enabled auto-merge (squash) January 23, 2026 07:58
@MinerYang
MinerYang merged commit a8343d3 into goharbor:main Jan 23, 2026
12 checks passed
@Vigilans

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants