Skip to content

x/pkgsite: unreadable links in deprecated sections in dark mode  #64387

Open

Description

@Manish-Giri

What is the URL of the page with the issue?

https://pkg.go.dev/io/ioutil

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36

Screenshot

image

What did you do?

Visited documentation for io/ioutil pkg.

What did you expect to see?

Readable links.

What did you see instead?

Unreadable links.

Activity

  1. added this to the Unreleased milestone on Nov 26, 2023
  2. changed the title [-]x/pkgsite: Links on io/ioutil (and possibly other packages) are not readable[/-] [+]x/pkgsite: unreadable links in deprecated sections in dark mode [/+] on Nov 26, 2023
  3. joeshin commented on Mar 22, 2024

    @joeshin

    Did this get fixed somehow? I'm seeing proper link colors in dark mode.

    Screen Shot 2024-03-21 at 9 50 53 PM

    cc: @seankhliao

  4. Deleplace commented on May 6, 2024

    @Deleplace
    Contributor

    @joeshin I don't think this has been fixed, and I'm still seeing the white-on-yellow (unreadable) links (Chrome, macOS).

    There may be a different display color for "visited" or "unvisited" links, but I couldn't trigger a fifferent color by visiting the links.

  5. Deleplace commented on May 6, 2024

    @Deleplace
    Contributor

    I'm seeing the better colors in (Firefox, macOS) and in (Chrome, Android)

  6. fzipp commented on May 7, 2024

    @fzipp
    Contributor

    I'm still seeing the white-on-yellow (unreadable) links (Chrome, macOS).

    @Deleplace

    I'm using the same combo (Chrome, macOS), however with no extensions, and my links are readable:

    deprecated comment links in dark mode user agent string

    Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36

  7. joeshin commented on May 7, 2024

    @joeshin

    @Deleplace @fzipp I was on the same combo of (MacOS Chrome). And visited links looked fine as well. Looking at CSS it appears that the "open" attribute is wonky somehow for some browsers? The default color IS white. So the open selector seems like it's not hitting.

    Screenshot 2024-05-07 at 11 57 34 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions