add custom nonce flag to cmd package token subcommand - #451
Merged
Conversation
Ruide
commented
May 17, 2024
Ruide
commented
Collaborator
- add a custom-nonce flag to allow user supplied string array for Custom Nonce
- added the flag in token subcommand for generating tokens with the custom nonce field
- added the flag in unit test
Collaborator
Author
|
/gcbrun |
alexmwu
requested changes
May 29, 2024
alexmwu
left a comment
alexmwu
left a comment
Contributor
There was a problem hiding this comment.
Please add a test that uses custom nonce and the fake verifier
JoshuaKrstic
approved these changes
May 29, 2024
Ruide
force-pushed
the
add-custom-nonce-flag
branch
from
May 29, 2024 23:56
e1c397f to
f0588c9
Compare
Collaborator
Author
|
/gcbrun |
alexmwu
approved these changes
May 30, 2024
Ruide
force-pushed
the
add-custom-nonce-flag
branch
from
May 31, 2024 01:03
f0588c9 to
3be9f02
Compare
Collaborator
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.