dql/fs: yieldAnyNodes fix

[xushiwei]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a fix for the yieldAnyNodes function within the dql/fs package, primarily by simplifying and correcting its internal logic for handling different node types (files and directories) during traversal. This enhancement enables proper recursive file matching, as illustrated by an updated example, and streamlines the code by removing unnecessary filtering variables and logic.

Highlights

• Recursive File Matching Enabled: The example in fsq.xgo was updated to use **.file.match, demonstrating that the underlying file system traversal now correctly supports recursive matching for files across subdirectories.
• Simplified Node Filtering Logic: The yieldAnyNodes function in fs.go was refactored to streamline the conditional logic for determining whether to yield a node based on its type (file, directory, or any), removing redundant variables and simplifying the if condition.
• Removed Redundant Filter Parameter: The filter parameter and its associated setup were removed from yieldAnyNodes, and yieldChildNodes is now called with nil for the filter, indicating a simplification in how node filtering is managed during traversal.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• demo/dql-fs/fsq.xgo
  • Updated the file matching pattern to **.file.match to demonstrate recursive file system traversal.
• dql/fs/fs.go
  • Simplified the conditional logic for yielding nodes based on their kind (file, directory, or any).
  • Removed the needDir and filter variables and their initialization.
  • Modified the call to yieldChildNodes to pass nil for the filter parameter.

Activity

• No human activity has been recorded on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (b8b24b1) to head (5e3caf6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2636   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files          32       32           
  Lines        9964     9964           
=======================================
  Hits         9377     9377           
  Misses        419      419           
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request provides a fix for a bug in the yieldAnyNodes function, which prevented correct recursive traversal for files (e.g., **.file). The previous logic incorrectly filtered out directories during child node traversal, thereby halting deep recursion. The new implementation corrects this by removing the premature filtering and consolidating the node-yielding condition. This change not only resolves the bug but also improves code clarity and conciseness. The update to fsq.xgo serves as a good regression test for this fix. The changes are well-implemented.