Restore configurable chaincode base image pull behavior - #5497
Merged
pfi79 merged 1 commit intoJun 16, 2026
Conversation
Contributor
|
please correct the unit test |
Signed-off-by: Drupadh Dinesh <drupadhdinesh@gmail.com>
drupadh-dinesh
force-pushed
the
fix/cc-base-image-pull-config
branch
from
June 16, 2026 13:46
1f0b7d8 to
0fc37e1
Compare
pfi79
approved these changes
Jun 16, 2026
Contributor
|
@drupadh-dinesh Thanks for your fix. |
pfi79
enabled auto-merge (squash)
June 16, 2026 13:48
pfi79
disabled auto-merge
June 16, 2026 14:20
Contributor
|
@Mergifyio backport release-2.5 |
✅ Backports have been createdDetails
|
pfi79
pushed a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore configurable chaincode base image pull behavior
Description
Prior to commit 138b6fa, pulling the chaincode base image was controlled by the chaincode.pull configuration option. After the Docker client update introduced in that commit, the base image pull behavior was effectively hardcoded to true, causing the base image to be pulled on every chaincode build regardless of the chaincode.pull setting.
This PR restores the previous behavior by honoring the chaincode.pull configuration option when deciding whether to pull the base image.
Additional details
This change is backward-compatible and restores the configurability that existed before commit 138b6fa.