Valid DateTime treated as invalid

[nirvdrum]

In JRuby 1.7.5 dev, DateTime.new(0) raises an ArgumentError and indicates it is an invalid date. This same invocation works fine in JRuby 1.7.4 and MRI 2.0.0-p247. My guess is the Joda-Time changes that made their way into 1.7.5 recently are the cause.

I can work around this in my app for now, but it seems an exception shouldn't be raised. As for a use case, I use this (clearly old) date is used as a null object for sorting operations.

[BanzaiMan]

irb(main):001:0> RUBY_DESCRIPTION
=> "jruby 1.7.5.dev (1.9.3p392) 2013-10-01 70428b0 on Java HotSpot(TM) 64-Bit Server VM 1.7.0_40-b43 [darwin-x86_64]"
irb(main):002:0> require 'date'
=> true
irb(main):003:0> DateTime.new(0)
ArgumentError: invalid date
        from /Users/asari/Development/src/jruby/lib/ruby/1.9/date.rb:1702:in `civil'
        from (irb):3:in `evaluate'
        from org/jruby/RubyKernel.java:1121:in `eval'
        from org/jruby/RubyKernel.java:1517:in `loop'
        from org/jruby/RubyKernel.java:1282:in `catch'
        from org/jruby/RubyKernel.java:1282:in `catch'
        from /Users/asari/Development/src/jruby/bin/jirb:13:in `(root)'

jruby/lib/ruby/1.9/date.rb

Lines 1699 to 1703 in 8d8f342

	begin
	dt = JODA::DateTime.new(y, m, d, h, min, s, ms, chronology(sg, of))
	rescue JODA::IllegalFieldValueException, Java::JavaLang::IllegalArgumentException
	raise ArgumentError, 'invalid date'
	end

[BanzaiMan]

By not rescuing the Joda exception, we get a more informative error message:

JulianChronology.java:80:in `adjustYearForSet': org.joda.time.IllegalFieldValueException: Value 0 for year is not supported
        from JulianChronology.java:207:in `getDateMidnightMillis'

[headius]

Copying @eregon and @enebo. This probably should be fixed before release... high priority.

[headius]

Oh...and we obviously need a test for this somewhere :-)

[eregon]

That off-by-one error ... tests added in test/ for simplicity (a428949).
Sorry about that, it is quite a problem to map joda-time years to Date years during Julian chronology.
Currently, the code assumes the calendar reform is always after year 0, or Date::GREGORIAN = -Infinity.new (anyway, joda-time does not support reform before 0001-01-01 and it makes no sense).

[eregon]

@nirvdrum BTW, you might want to use simply DateTime.new (that is -4712-01-01, jd 0) as an older-than-anything date.

[nirvdrum]

Ahh, thanks for the tip.

[BanzaiMan]

I cherry-picked these commits to the 1.7 branch as e3b1080 and 47e7cb5.

[nirvdrum]

Looking good for me now. Thanks for the quick turnaround.

[headius]

Thanks for fixing, @eregon!