updating min-content and max-content support information for Firefox … - #3573
Closed
chrisdavidmills wants to merge 1 commit into
Closed
updating min-content and max-content support information for Firefox …#3573chrisdavidmills wants to merge 1 commit into
chrisdavidmills wants to merge 1 commit into
Conversation
…now it is available unprefixed
Elchi3
added
the
data:css
Contributor
|
Just a heads up here, but I think there's going to be a conflict with #3457 |
Contributor
Author
|
@ddbeck ack, dammnit, I forgot Rachel did this! Well, I'd much rather merge Rachel's PR first, then perhaos close mine and just add in any missing details I uncovered. It looks like she did mostly the same thing as me, but with some better testing across browsers. |
Contributor
|
Yeah, I think the combination of your two PRs will be great (in particular, I think you picked up some prefix data that's not in Rachel's PR). I'll mark this as not-ready for now and you can decide whether to close or risk a rebase after Rachel's PR is merged |
ddbeck
added
the
not ready
Contributor
|
#3457 has been merged, @chrisdavidmills. I'll leave it to you whether to rebase or open a new PR. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…now it is available unprefixed
Firefox now supports the
max-contentandmin-contentkeywords unprefixed for all of the properties listed at https://bugzilla.mozilla.org/show_bug.cgi?id=1322780#c60.This is an attempt to update them. I also did a bit of breaking out these keywords (and
fit-content) onto separate support data lines where they were represeted all in one item because it just didn't make sense to have them lumped together.