NRG: Meta election fails if gateway host resolves to multiple IPs

[MauriceVanVeen]

bootstrapRaftNode now counts each gateway URL as a single peer when estimating the JetStream meta group size, rather than resolving the host and adding one peer per IP. A dual-stack host would inflate the expected cluster size above the real node count, and result in initial meta election stalling.

[synadia-claude-reviewer]

Claude finished @MauriceVanVeen's task in 2m 15s —— View job

---

Code Review

• Gather context (PR diff, CLAUDE.md, relevant source files)
• Analyze changes for correctness, concurrency safety, and raft semantics
• Post review feedback

---

Summary

The fix is correct and well-targeted. The root cause was that net.LookupHost on a dual-stack hostname (e.g. "localhost") returns both 127.0.0.1 and ::1, causing ngwps to be incremented twice for what is a single server, which inflated the expected meta-group size and stalled leader election.

Consistency with route counting: nrs := len(opts.Routes) already uses URL count directly (line 369), making ngwps += len(gw.URLs) (line 384) a natural and consistent change.

Performance improvement: The old path called net.LookupHost for every non-IP hostname during bootstrap. The new path does no network I/O and is deterministic.

Test quality: TestNRGBootstrapExpectedClusterSize covers IP literals, dual-stack hostnames, and multiple remote clusters. The partially-initialised &Server{opts: opts} is safe because s.mu and s.optsMu are zero-value sync.RWMutex values, which are valid for use without explicit initialisation.

---

One thing to verify

ngwps += len(gw.URLs) inherits the same assumption that was already implicit for IP-literal hosts: one URL = one distinct server. This holds as long as operators don't list the same gateway server twice under different names or ports. That was equally true before the fix, and it's the standard configuration pattern — so this is fine as a heuristic for bootstrapping.

No bugs, no security issues, no blocking concerns. Good fix.

[neilalexander]

LGTM