nsqd: ability to configure auth endpoint path

[tufanbarisyildirim]

added ability to provide full url as auth endpoint #1336

[Misiu]

What about https? I think it should be supported. This solution will work if we specify full url that starts with 'http'

[tufanbarisyildirim]

What about https? I think it should be supported. This solution will work if we specify full url that starts with 'http'

https starts with http, so, both should work. @Misiu

[ploxiln]

Yeah, https should work fine.

But another possible objection is that a hostname could start with "http", like httpcluster01.company.org, so perhaps strings.Contains(authd, "://") would be a more precise condition.

[Misiu]

https starts with http, so, both should work. @Misiu

it's definitively too late for a review.
Sorry for the confusion. I can confirm that HTTPS starts with HTTP :)

[tufanbarisyildirim]

Yeah, https should work fine.

But another possible objection is that a hostname could start with "http", like httpcluster01.company.org, so perhaps strings.Contains(authd, "://") would be a more precise condition.

yeah, good point, you add and commit it quickly maybe? since this is merged already.

[ploxiln]

Do you want to open a new pull request with that change 😁
I think it's fine to take a day or two, because this "feature" is not in a release yet.