Skip to content

nsqadmin: add admin check for topic/node thombstone endpoint - #1462

Merged
jehiah merged 1 commit into
nsqio:masterfrom
dudleycarr:fix-admin-check-tombstoneNodeForTopic
Oct 24, 2023
Merged

nsqadmin: add admin check for topic/node thombstone endpoint#1462
jehiah merged 1 commit into
nsqio:masterfrom
dudleycarr:fix-admin-check-tombstoneNodeForTopic

Conversation

@dudleycarr

Copy link
Copy Markdown
Contributor

Fixes: #1390

Screen.Recording.2023-09-28.at.3.51.49.PM.mov

@dudleycarr dudleycarr changed the title fix: add admin check for topic/node thombstone endpoint nsqadmin: add admin check for topic/node thombstone endpoint Sep 28, 2023
Comment thread nsqadmin/http.go Outdated
@jehiah

jehiah commented Oct 24, 2023

Copy link
Copy Markdown
Member

@dudleycarr can you squash these two commits and i'll land this change as well.

@dudleycarr
dudleycarr force-pushed the fix-admin-check-tombstoneNodeForTopic branch from e17e8f7 to fc75506 Compare October 24, 2023 18:08
@dudleycarr

Copy link
Copy Markdown
Contributor Author

Squashed!

@jehiah
jehiah merged commit 9a8c304 into nsqio:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nsqadmin: non admin user can delete the topic on a node

2 participants