HTTP response format continued - #366
Conversation
|
LGTM. ready for this to land? |
|
not yet, gonna do the forwards/backwards compatibility crap between daemons |
There was a problem hiding this comment.
btw, I have to do this anonymous function junk to maintain compatibility with go1.0.3
There was a problem hiding this comment.
much appreciated =).
inching closer to not needing that.
|
I have a bit more work to do here but this is the last PR I'd like to get in for this next release |
|
this is ready for review, but I intend on doing a few more things:
|
There was a problem hiding this comment.
Technically we could put this in the actual content-type response "application/json; charset=utf-8; nsq-version=1.0"
There was a problem hiding this comment.
I would be worried about shitty HTTP clients that this might screw up...
I copied the GitHub API, FWIW.
|
Changes look pretty sane to me. |
…nt endpoint names
@jehiah noticed that we didn't update
nsqlookupdHTTP response formats in #330took advantage of the opportunity to make the code a little more modular and reusable