Improved pull request "Files Changed" experience feedback #163932
Replies: 3170 comments 1300 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
It doesn't always seem to remember if hide whitespace was turned on. |
|
I just did a review on a multi-commit PR, and did so commit by commit. As I went on, I left remarks added to my pending review. A review on commit 3 in line 100 of a file stuck at line 100 in commit 4, where the line actually moved to 120 after code was added before it. The result is a final review that puts the remark in the wrong location. Going back to commit 3 shows it in the correct location, but the final review panel also shows all other remarks (from later commits) as "Outdated". Effectively, I had to re-add all my remarks in the full diff (across all commits) to get them into the correct location. And that makes this barely usable for scoped reviews. |
Feature Request: Add "Viewed" indicators directly into the PR File Tree DrawerWhy the current "Hide viewed" filter isn't enough: While GitHub currently offers a filter to entirely hide viewed files, this solution is disruptive for larger code reviews. Hiding files completely collapses the directory layout, which breaks the reviewer's mental model of the codebase architecture. Furthermore, if a reviewer needs to quickly reference or double-check a file they just marked as viewed, they are forced to toggle the filter off, locate the file, and turn the filter back on—adding unnecessary friction to the workflow. Proposed Solution: This will drastically improve navigation ergonomics for large reviews so we don't have to keep scrolling through the main diff pane to track what remains. |
|
Please add a filter to the file drawer to hide moved, but unchanged, files. |
|
Seeing pretty extreme lag with this new feature. A PR with ~110 files changed, +-1-2k lines changed is basically unreviewable at this point. This size of PR used to be fine a while ago. Memory usage is 1GB+ and CPU spikes to over 100% when scrolling the PR. Classic experience is slightly better but still pretty bad. |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Looks great! Commenting on any line and the improved performance are big quality-of-life improvements. Thanks for sharing the roadmap and actively listening to community feedback. |
|
Is there a more intuitive way to minimize all diffs in the new UI other than holding ALT and pressing the inverse caret icon on one diff? Would be great 🙂 |
|
I just noticed that the CODEOWNERS validation is only shown in the classic UI. The preview version does not include it. I caught this because someone let a PR through with a typo, which caused ownership of the line item to revert to the upper assignment. |
|
Would like an option to always enable single file mode. Thanks! |
|
I appreciate trying to add conveniences like a slide panel with info you'd otherwise have to nav to another page for, but it's patching symptoms of bad IA instead of fixing the root causes. On the changes tab, instead of having individual sub-tabs-in-a-popup-hiding-in-a-dropdown, could you just take the conversation tab and shove it into the expandable pane almost like it is in that tab? One pane, all the information you want to see in a familiar scroll view. Still not a great solution as that information would probably be better combined in a single pane experience with the code changes, but it's better than the disjoint nav experience the current slide panel has going on. (please, please consider a single pane experience and get rid of all the tabs) |
|
Interacting with review comments after the code has been updated is the most frustrating part of the new experience for me. When I click a comment that was left on code that has since changed, the page switches me to the commit range the comment was made on instead of staying on all changes. I understand why, since the line no longer exists in the latest diff, but what I actually need at that moment is to check whether the concern was addressed. There's no path from the comment to the current state of that code, so I end up resetting the selector back to "All commits" and hunting for the file manually. On a PR with a few rounds of review this happens over and over. A couple of things also appear broken in this flow (Firefox on macOS):
The workflow I'm hoping for: from a comment thread, let me see the code as it was when the comment was made and the code as it is now, one click apart at most. The classic Conversation tab got partway there by inlining the outdated hunk. Right now I can't reliably get to either view from the Comments panel. |
|
Overall I'm fine with new Files Changed UI, but one issue I have is that inline comments are hidden by default. There's the little user icon on the right side of the code where I can click to show the comment that was left there, but it's very easy to miss that and not realize there was a comment there at all. I like the ability to hide an inline comment, but I want them all to be visible by default, so that I know they're there. |





















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions