Skip to content

Add TOML icon - #1436

Merged
Finii merged 2 commits into
ryanoasis:masterfrom
cpea2506:add-toml-icon
Nov 26, 2023
Merged

Add TOML icon#1436
Finii merged 2 commits into
ryanoasis:masterfrom
cpea2506:add-toml-icon

Conversation

@cpea2506

@cpea2506 cpea2506 commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

Description

The logo is taken from the official repo of TOML.

There is a little change that made the SVG change to black/white color and better optimized.

Requirements / Checklist

What does this Pull Request (PR) do?

Add new icon for TOML

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Screenshot 2023-11-22 at 23 12 49

@Finii

Finii commented Nov 22, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the nice PR!

Just curiosity, what is your use-case? Yes, to mark your TOML files, I mean what do you use TOML for?
I had the impression everybody is using json these days, even if the readability is less.

@cpea2506

cpea2506 commented Nov 23, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the nice PR!

Just curiosity, what is your use-case? Yes, to mark your TOML files, I mean what do you use TOML for? I had the impression everybody is using json these days, even if the readability is less.

Hi, as a Rust user we work with a lot of TOML files since Rust prefer them for readability and minimal syntax.

@Finii

Finii commented Nov 26, 2023

Copy link
Copy Markdown
Collaborator

Sneaking this in, thanks again

@Finii
Finii merged commit a58d12d into ryanoasis:master Nov 26, 2023
@cpea2506
cpea2506 deleted the add-toml-icon branch November 26, 2023 15:07
@Finii

Finii commented Nov 26, 2023

Copy link
Copy Markdown
Collaborator

@allcontributors please add @cpea2506 for code

@allcontributors

Copy link
Copy Markdown
Contributor

@Finii

I've put up a pull request to add @cpea2506! 🎉

@jcypret

jcypret commented Feb 25, 2024

Copy link
Copy Markdown

Excited to see this TOML addition! ❤️

FYI: It looks like the Glyph Sets and Code Points Wiki entry is missing this additional codepoint:

- Code Point Ranges: e5fa-e6b1
+ Code Point Ranges: e5fa-e6b2

I noticed when using that wiki as a reference for my Kitty config based on this other discussion: #1189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants