|
Finally the dark UI is here but in the logger, all is still horrible. |
Replies: 22 comments 41 replies
Elaborate on what is "horrible". |
How is this constructive? To be constructive you need to be very specific about what needs to be fixed, otherwise we have no idea what you think requires fixing, and no action taken as a result. |
|
Sorry guys you are right. This screenshot is taken from Firefox 97 final and UBO 1.40.9b11 on Windows 7.
|
|
I can reproduce the "Click to preview" issue, I will fix this. I cannot reproduce the illegible line in the logger, mine is light text on dark background. Maybe you have remnant of customizations for uBO's CSS, you should remove all these to be sure they are not interfering with uBO's official support of dark theme. |
|
Web Workers are always shadowed, perhaps shadows won't work with dark theme. |
|
Any link which I can simply navigate to so that I get webworker entries? |
|
|
Blinking white background when dark theme is active. gif
DetailsuBlock Origin: 1.40.9rc0
Chromium: 98
filterset (summary):
network: 96192
cosmetic: 62224
scriptlet: 18070
html: 0
listset (total-discarded, last updated):
default:
user-filters: 0-0, never
RUS-0: 41141-9, 7m
easylist: 62829-20, 7m
easyprivacy: 26696-113, 7m
plowe-0: 3677-822, 7m
ublock-abuse: 77-1, 7m
ublock-badware: 3831-72, 7m
ublock-filters: 30183-181, 7m
ublock-privacy: 194-2, 7m
ublock-unbreak: 1699-39, 7m
urlhaus-1: 7611-0, 7m
filterset (user): [empty]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats:
allReadyAfter: 359 ms (selfie)
maxAssetCacheWait: 229 ms
popupPanel:
blocked: 1
blockedDetails:
github.com: 1 |
|
@happysurf provide an exact URL which I can use to reproduce exactly what you get in your logger. Ok I forced an update of one of uBO's list, and tabless network requests shows up fine in dark mode, i.e. light text on dark background, so I can't still reproduce that illegible line in your screenshot. |
|
Since we're talking about the logger's dark UI, may I request some changes?
Screenshot
mediumblue is rather hard to read on a dark background. Especially when looking from a distance, suffering from eye-strain or generally for people with slightly worse vision.blue is only slightly better - I'm proposing changing it to something like deepskyblue or cyan, if we need to stay with blue variants.
Changing the color to one of these lighter hues will also kinda fix the issue with shadowed web workers as mentioned in @happysurf 's comment and @uBlock-user 's reply. Screenshot for comparison
Screenshots
Could we get these fixed, please? |
|
CNAME is |
Yeah, I guess using |
|
Cname in logger is just something I overlooked, I didn't choose this specifically, the proper one is the one already defined for the popup panel, so I will change this. For the form widget, I prefer to let the browser or OS deal with these, I would expect it would do so when dark mode is set browser- or system-wide. |
|
I have both system-wide and browse-wide dark modes and the dropdown entries remain dark, it's just the initial fields that show up white in uBO.
|
|
On my side I have these fields in a light color, including the drop down -- uBO does not change the background color on these, I decided to refrain from doing so a long time ago because of bad side effect in the appearance of built-in widgets. The filter expression overlay is a custom div though, so it will be affected by default background color. |
|
The link for try the logger is https://pixcut.wondershare.com/account.html |
|
Ok, so these were cname-related entries, fixed with gorhill/uBlock@3549043 as per above feedback. |
|
These dark CNAME lines are from closed tabs. Open
|
Just to be clear, in the main commit for dark mode, I pointed out that I don't expect it to be complete everywhere, there is a lot of corners in uBO, and that I will fix as per feedback -- this is what we are doing here. So if you see a bad color choice, it's not because I thought this was a good idea, it's just something which I overlooked -- there were a huge amount of CSS-related changes and at some point I had to commit what I had without waiting to have 100% coverage by trying to find everything on my own. |
|
All form widgets in all uBO panes are white on dark themes or when set to auto(browser theme set to dark.). |
|
As said, I won't touch form widgets, this is opening a can of worms -- the appearance of these is controlled by the browser. If you expect them to be modified by dark theme in the browser, you will have to open an issue about this with the browser devs. |
|
There's an issue with the selection color in CodeMirror (does picker use CodeMirror too?) if the window becomes inactive. E.g. when snapping two windows to screen edges to test filters on two different browser profiles.
|
|
I'm going to have to research to find out if it's possible. |
|
Slight correction. The color change also happens in the same browser window when shifting focus to another item (e.g. clicking outside the textarea in "My Filters" or when trying to drag the Picker box whilst its contents are selected). |
|
Should be improved with gorhill/uBlock@ed25ed6. |
|
Thanks. I'll try it out when the next rc goes live. |
|
|
|
Dark theme is not applied after session restore. Both in dashboard and logger window. Firefox 98.0a1, 1.40.9rc1, system and browser set to default theme (light). |
|
You mean when uBO's own pages are already opened as part of the session? If so, this is #1669. |
|
The Click2Load text is not visible.
Result: |
|
Should be fixed with gorhill/uBlock@e44768f. |
|
A minor cosmetic issue - any chances for a slightly higher contrast between the background and the font in Picker's counter? Be it either a darker background or a darker (black?) font. I know these haven't changed since the Light theme, but I think it's just a tad more difficult for the eye to adjust to white on light grey from the darker colors everywhere else than it is on the light theme. Though, I also did have trouble (on occasion) reading the numbers on there in the past (due to eye strain or wherever). |
|
Fixed with gorhill/uBlock@ed1b5e2. |
|
Just thinking out loud here, but do you think using Perhaps using Also, not entirely related, but I was wondering if using 4 color variables for |
|
I use a lot this guide to make decisions, and this is the case here. It says medium emphasis should use text at opacity 60, and this is what I did. I checked the resulting color versus the background, and I get a AA+ contrast ratio, which means it passes the contrast test. I prefer to stick to the material design guide to make this sort of decision, otherwise every decision become subjective and as such candidate for endless debate because everybody has their own opinion when subjectivity is involved. |
|
I see. I just figured I'd ask since the opacity is a new addition. Thanks for clarifying. |
|
The shadows problems remain on 1.40.9rc1.
|
|
I consider the shadow issue to be a long standing issue, I found it was problematic before as well, and I will need to research something which work better than using a text shadow regardless of theme. The context information is what helps distinguish tabless requests, their root context is always |
Screenshot
Adding |
I think this option is a hint for the browser, it says that the page supports dark/light schemes. If the page does not support them ( What wonders me is that from the "Compatibility" section, it looks like the only supported value is |
|
Supported value is |
.dark input, .dark select, .dark textarea {
color-scheme: dark;
}Wouldn't that work? |
|
Thanks for reminding me, I was planning to use |
|
IMO no works good #2062 |
|
Theme set is "auto" There's Screenshot
is it by design now? if yes then doesn't look good |
|
Fixed with gorhill/uBlock@9a5acbb. |
|
The icon at the bottom of "my rules" is hard to see in dark mode. But to be fair, it's hard to see in light mode as well.
|
|
Fixed with gorhill/uBlock@3e2f779. |
|
Could |
|
Suggest a replacement color? |
|
If you look edit history of this comment you can see that I originally had suggestion, but I edited it out because I thought that maybe it was too aggressive color. But something like that where it clearly stands out that there's asterisks in the url, for example. |
|
What is the hex color code in your screenshot? |
|
|
|
Your hue is ~308, the original is 280 -- so for the next dev build I will nudge the hue to 290 and wait for feedback. |
|
Logger's |
|
In the dark theme, the noop rules in the popup panel have reversed colors - inherited ones are dark gray. |
|
The inherited ones are closer to the color of the ones without rules, so in the light theme they are lighter gray, in the dark theme they are darker gray. Same applies to the block/allow rules, the lightness of the color on inherited rules is between the lightness of the color of the rule and the default lightness of the background. |
|
A very minor issue. In the logger, when on the "All" tab, the message about filter lists being reloaded is nearly invisible with its dark blue font color on a dark grey background. |
Just to be clear, in the main commit for dark mode, I pointed out that I don't expect it to be complete everywhere, there is a lot of corners in uBO, and that I will fix as per feedback -- this is what we are doing here. So if you see a bad color choice, it's not because I thought this was a good idea, it's just something which I overlooked -- there were a huge amount of CSS-related changes and at some point I had to commit what I had without waiting to have 100% coverage by trying to find everything on my own.