c/lua:custom alloc - #796
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 97.53% 97.54%
=======================================
Files 19 19
Lines 4668 4683 +15
=======================================
+ Hits 4553 4568 +15
Misses 97 97
Partials 18 18 ☔ View full report in Codecov by Sentry. |
xushiwei
reviewed
Sep 17, 2024
| //go:linkname Newstate C.luaL_newstate | ||
| func Newstate() *State | ||
| //go:linkname Newstate__1 C.luaL_newstate | ||
| func Newstate__1() *State { return nil } |
Contributor
There was a problem hiding this comment.
为啥要修改这个函数名？
另外，go:linkname 是不需要函数 body 的
Contributor
Author
There was a problem hiding this comment.
多个头文件中，会出现去掉对应前缀后，函数名一样的情况（这里即luaL_newState和lua_newState，luaL和lua都视为需要移除的前缀），在后续自动生成工具看来这种函数即视为重载函数，所以这里将对应的两个函数改成newstate__0，newstate__1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.